Aggregate BlindedPayInfo for blinded routes
#2514
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valentinewallace
force-pushed
the
2023-08-compute-blindedpayinfo
branch
from
d60f441 to
63025f8
Compare
Codecov ReportPatch coverage:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #2514 +/- ##
========================================
Coverage 90.59% 90.59%
========================================
Files 110 110
Lines 57410 58062 +652
Branches 57410 58062 +652
========================================
+ Hits 52008 52602 +594
- Misses 5402 5460 +58
☔ View full report in Codecov by Sentry. 📢 Have feedback on the report? Share it here. |
valentinewallace
force-pushed
the
2023-08-compute-blindedpayinfo
branch
from
63025f8 to
e87c68e
Compare
TheBlueMatt
reviewed
Aug 23, 2023
valentinewallace
force-pushed
the
2023-08-compute-blindedpayinfo
branch
2 times, most recently
from
b159729 to
35b1dc8
Compare
alecchendev
reviewed
Aug 25, 2023
valentinewallace
force-pushed
the
2023-08-compute-blindedpayinfo
branch
3 times, most recently
from
c6df2b6 to
4b9f000
Compare
valentinewallace
force-pushed
the
2023-08-compute-blindedpayinfo
branch
from
4b9f000 to
3ec7789
Compare
|
Rebased to fix CI. I added test coverage for the min htlc computation to #2413 so this should be good for review. |
TheBlueMatt
reviewed
Aug 28, 2023
jkczyz
reviewed
Aug 28, 2023
valentinewallace
force-pushed
the
2023-08-compute-blindedpayinfo
branch
5 times, most recently
from
f272645 to
5d0a982
Compare
alecchendev
reviewed
Aug 31, 2023
TheBlueMatt
reviewed
Sep 1, 2023
TheBlueMatt
reviewed
Sep 4, 2023
valentinewallace
force-pushed
the
2023-08-compute-blindedpayinfo
branch
from
5d0a982 to
4777c29
Compare
valentinewallace
commented
Sep 6, 2023
TheBlueMatt
reviewed
Sep 6, 2023
TheBlueMatt
reviewed
Sep 6, 2023
TheBlueMatt
reviewed
Sep 6, 2023
valentinewallace
force-pushed
the
2023-08-compute-blindedpayinfo
branch
from
4777c29 to
a6f881b
Compare
|
I think I addressed all feedback. Thought I saw something about not decrementing htlc_min but I don't see it anymore? |
valentinewallace
force-pushed
the
2023-08-compute-blindedpayinfo
branch
from
a6f881b to
88a0063
Compare
valentinewallace
commented
Sep 7, 2023
TheBlueMatt
previously approved these changes
Sep 8, 2023
valentinewallace
force-pushed
the
2023-08-compute-blindedpayinfo
branch
2 times, most recently
from
61658ae to
a1b3fbb
Compare
These should've been made public when they were added for use in BlindedPath::new_for_payment.
impl_writeable_tlv_based includes a length prefix to the TLV stream, which we don't want.
valentinewallace
force-pushed
the
2023-08-compute-blindedpayinfo
branch
from
a1b3fbb to
f3616e6
Compare
TheBlueMatt
approved these changes
Sep 8, 2023
jkczyz
approved these changes
Sep 9, 2023
60 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BOLT 12 invoices encode
BlindedPayInfo(s) as part of their hints for routing, whose fields are computed by aggregating fee/cltv/etc values from the hops along the blinded path. Helps address #1970.Based on #2412.